[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/16] migration: Unify failure check for migrate_add_blocker
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 09/16] migration: Unify failure check for migrate_add_blocker() |
|
Date: |
Tue, 20 Jul 2021 20:05:13 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 7/20/21 2:54 PM, Markus Armbruster wrote:
> Most callers check the return value. Some check whether it set an
> error. Functionally equivalent, but the former tends to be easier on
> the eyes, so do that everywhere.
>
> Prior art: commit c6ecec43b2 "qemu-option: Check return value instead
> of @err where convenient".
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> backends/tpm/tpm_emulator.c | 3 +--
> hw/display/qxl.c | 8 ++++----
> hw/virtio/vhost.c | 2 +-
> target/i386/kvm/kvm.c | 6 +++---
> target/i386/nvmm/nvmm-all.c | 3 +--
> target/i386/whpx/whpx-all.c | 3 +--
> 6 files changed, 11 insertions(+), 14 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH 00/16] Various error handling fixes and cleanups, Markus Armbruster, 2021/07/20
- [PATCH 02/16] spapr: Plug memory leak when we can't add a migration blocker, Markus Armbruster, 2021/07/20
- [PATCH 06/16] i386: Never free migration blocker objects instead of sometimes, Markus Armbruster, 2021/07/20
- [PATCH 09/16] migration: Unify failure check for migrate_add_blocker(), Markus Armbruster, 2021/07/20
- Re: [PATCH 09/16] migration: Unify failure check for migrate_add_blocker(),
Philippe Mathieu-Daudé <=
- [PATCH 10/16] migration: Handle migration_incoming_setup() errors consistently, Markus Armbruster, 2021/07/20
- [PATCH 03/16] spapr: Explain purpose of ->fwnmi_migration_blocker more clearly, Markus Armbruster, 2021/07/20
- [PATCH 08/16] whpx nvmm: Drop useless migrate_del_blocker(), Markus Armbruster, 2021/07/20
- [PATCH 07/16] vfio: Avoid error_propagate() after migrate_add_blocker(), Markus Armbruster, 2021/07/20