[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-6.1] gitlab-ci: Extract OpenSBI job rules to reusable sec

From: Alex Bennée
Subject: Re: [PATCH-for-6.1] gitlab-ci: Extract OpenSBI job rules to reusable section
Date: Tue, 20 Jul 2021 23:15:50 +0100
User-agent: mu4e 1.5.14; emacs 28.0.50

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> All jobs depending on 'docker-opensbi' job must use at most all
> the rules that triggers it. The simplest way to ensure that
> is to always use the same rules. Extract all the rules to a
> reusable section, and include this section (with the 'extends'
> keyword) in both 'docker-opensbi' and 'build-opensbi' jobs.
> The problem was introduced in commit c6fc0fc1a71 ("gitlab-ci.yml:
> Add jobs to build OpenSBI firmware binaries"), but was revealed in
> commit 91e9c47e50a ("docker: OpenSBI build job depends on OpenSBI
> container").
> This fix is similar to the one used with the EDK2 firmware job in
> commit ac0595cf6b3 ("gitlab-ci: Extract EDK2 job rules to reusable
> section").
> Reported-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Queued to for-6.1/fixes-for-rc1, thanks.

Alex Bennée

reply via email to

[Prev in Thread] Current Thread [Next in Thread]