[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-6.2 14/23] target/mips: Drop exit checks for singlestep_enabl
From: |
Richard Henderson |
Subject: |
[PATCH for-6.2 14/23] target/mips: Drop exit checks for singlestep_enabled |
Date: |
Tue, 20 Jul 2021 20:41:46 -1000 |
GDB single-stepping is now handled generically.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/mips/tcg/translate.c | 50 +++++++++++++------------------------
1 file changed, 18 insertions(+), 32 deletions(-)
diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c
index 4d1e08cfb1..cc24d443cf 100644
--- a/target/mips/tcg/translate.c
+++ b/target/mips/tcg/translate.c
@@ -4954,12 +4954,7 @@ static void gen_goto_tb(DisasContext *ctx, int n,
target_ulong dest)
tcg_gen_exit_tb(ctx->base.tb, n);
} else {
gen_save_pc(dest);
- if (ctx->base.singlestep_enabled) {
- save_cpu_state(ctx, 0);
- gen_helper_raise_exception_debug(cpu_env);
- } else {
- tcg_gen_lookup_and_goto_ptr();
- }
+ tcg_gen_lookup_and_goto_ptr();
}
}
@@ -11929,10 +11924,6 @@ static void gen_branch(DisasContext *ctx, int
insn_bytes)
} else {
tcg_gen_mov_tl(cpu_PC, btarget);
}
- if (ctx->base.singlestep_enabled) {
- save_cpu_state(ctx, 0);
- gen_helper_raise_exception_debug(cpu_env);
- }
tcg_gen_lookup_and_goto_ptr();
break;
default:
@@ -16257,28 +16248,23 @@ static void mips_tr_tb_stop(DisasContextBase *dcbase,
CPUState *cs)
{
DisasContext *ctx = container_of(dcbase, DisasContext, base);
- if (ctx->base.singlestep_enabled && ctx->base.is_jmp != DISAS_NORETURN) {
- save_cpu_state(ctx, ctx->base.is_jmp != DISAS_EXIT);
- gen_helper_raise_exception_debug(cpu_env);
- } else {
- switch (ctx->base.is_jmp) {
- case DISAS_STOP:
- gen_save_pc(ctx->base.pc_next);
- tcg_gen_lookup_and_goto_ptr();
- break;
- case DISAS_NEXT:
- case DISAS_TOO_MANY:
- save_cpu_state(ctx, 0);
- gen_goto_tb(ctx, 0, ctx->base.pc_next);
- break;
- case DISAS_EXIT:
- tcg_gen_exit_tb(NULL, 0);
- break;
- case DISAS_NORETURN:
- break;
- default:
- g_assert_not_reached();
- }
+ switch (ctx->base.is_jmp) {
+ case DISAS_STOP:
+ gen_save_pc(ctx->base.pc_next);
+ tcg_gen_lookup_and_goto_ptr();
+ break;
+ case DISAS_NEXT:
+ case DISAS_TOO_MANY:
+ save_cpu_state(ctx, 0);
+ gen_goto_tb(ctx, 0, ctx->base.pc_next);
+ break;
+ case DISAS_EXIT:
+ tcg_gen_exit_tb(NULL, 0);
+ break;
+ case DISAS_NORETURN:
+ break;
+ default:
+ g_assert_not_reached();
}
}
--
2.25.1
- [PATCH for-6.2 01/23] accel/tcg: Handle gdb singlestep in cpu_tb_exec, (continued)
- [PATCH for-6.2 01/23] accel/tcg: Handle gdb singlestep in cpu_tb_exec, Richard Henderson, 2021/07/21
- [PATCH for-6.2 02/23] target/alpha: Drop checks for singlestep_enabled, Richard Henderson, 2021/07/21
- [PATCH for-6.2 03/23] target/avr: Drop checks for singlestep_enabled, Richard Henderson, 2021/07/21
- [PATCH for-6.2 04/23] target/cris: Drop checks for singlestep_enabled, Richard Henderson, 2021/07/21
- [PATCH for-6.2 06/23] target/arm: Drop checks for singlestep_enabled, Richard Henderson, 2021/07/21
- [PATCH for-6.2 07/23] target/hppa: Drop checks for singlestep_enabled, Richard Henderson, 2021/07/21
- [PATCH for-6.2 08/23] target/i386: Check CF_NO_GOTO_TB for dc->jmp_opt, Richard Henderson, 2021/07/21
- [PATCH for-6.2 13/23] target/mips: Fix single stepping, Richard Henderson, 2021/07/21
- [PATCH for-6.2 14/23] target/mips: Drop exit checks for singlestep_enabled,
Richard Henderson <=
- [PATCH for-6.2 15/23] target/openrisc: Drop checks for singlestep_enabled, Richard Henderson, 2021/07/21
- [PATCH for-6.2 05/23] target/hexagon: Drop checks for singlestep_enabled, Richard Henderson, 2021/07/21
- [PATCH for-6.2 09/23] target/i386: Drop check for singlestep_enabled, Richard Henderson, 2021/07/21
- [PATCH for-6.2 10/23] target/m68k: Drop checks for singlestep_enabled, Richard Henderson, 2021/07/21
- [PATCH for-6.2 11/23] target/microblaze: Check CF_NO_GOTO_TB for DISAS_JUMP, Richard Henderson, 2021/07/21
- [PATCH for-6.2 12/23] target/microblaze: Drop checks for singlestep_enabled, Richard Henderson, 2021/07/21
- [PATCH for-6.2 16/23] target/ppc: Drop exit checks for singlestep_enabled, Richard Henderson, 2021/07/21
- [PATCH for-6.2 20/23] target/s390x: Drop check for singlestep_enabled, Richard Henderson, 2021/07/21