[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] migration: Shutdown src in await_return_path_close_on_so
Daniel P . Berrangé
Re: [PATCH 2/5] migration: Shutdown src in await_return_path_close_on_source()
Wed, 21 Jul 2021 16:57:47 +0100
On Wed, Jul 21, 2021 at 10:55:00AM +0100, Dr. David Alan Gilbert wrote:
> * Peter Xu (email@example.com) wrote:
> > We have a logic in await_return_path_close_on_source() that we will
> > explicitly
> > shutdown the socket when migration encounters errors. However it could be
> > racy
> > because from_dst_file could have been reset right after checking it but
> > before
> > passing it to qemu_file_shutdown() by the rp_thread.
> > Fix it by shutdown() on the src file instead. Since they must be a pair of
> > qemu files, shutdown on either of them will work the same.
> > Since at it, drop the check for from_dst_file directly, which makes the
> > behavior even more predictable.
> So while the existing code maybe racy, I'm not sure that this change
> keeps the semantics; the channel may well have dup()'d the fd's for the
> two directions, and I'm not convinced that a shutdown() on one will
> necessarily impact the other; and if the shutdown doesn't happen the
> rp_thread might not exit, and we might block on the koin.
My understanding is that 'shutdown' operation affects the state of
the socket connection. An FD is merely the way a socket is exposed
to userspace. Thus if you have multiple FDs all pointing to the same
underlying socket (thanks to dup()), then I expect that the effects
of 'shutdown' will apply equally to all of the FD copies.
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
[PATCH 3/5] migration: Introduce migration_ioc_[un]register_yank(), Peter Xu, 2021/07/20
[PATCH 4/5] migration: Teach QEMUFile to be QIOChannel-aware, Peter Xu, 2021/07/20
[PATCH 5/5] migration: Move the yank unregister of channel_close out, Peter Xu, 2021/07/20