Re: [PATCH v5 05/10] ACPI ERST: support for ACPI ERST feature

[Eric DeVolder]

On 7/20/21 7:17 AM, Igor Mammedov wrote:
> On Wed, 30 Jun 2021 15:07:16 -0400
> Eric DeVolder <eric.devolder@oracle.com> wrote:
> > +
> > +static const TypeInfo erst_type_info = {
> > +    .name          = TYPE_ACPI_ERST,
> > +    .parent        = TYPE_PCI_DEVICE,
> > +    .class_init    = erst_class_init,
> > +    .instance_size = sizeof(ERSTDeviceState),
> > +    .interfaces = (InterfaceInfo[]) {
> > +        { INTERFACE_CONVENTIONAL_PCI_DEVICE },
> what is this for here?

Without this, at run-time, I obtain:
qemu-system-x86_64: ../hw/pci/pci.c:2673: pci_device_class_base_init: Asse
rtion `conventional || pcie' failed.

> > +        { }
> > +    }
> > +};
> > +
> > +static void erst_register_types(void)
> > +{
> > +    type_register_static(&erst_type_info);
> > +}
> > +
> > +type_init(erst_register_types)
> > diff --git a/hw/acpi/meson.build b/hw/acpi/meson.build
> > index dd69577..262a8ee 100644
> > --- a/hw/acpi/meson.build
> > +++ b/hw/acpi/meson.build
> > @@ -4,6 +4,7 @@ acpi_ss.add(files(
> >     'aml-build.c',
> >     'bios-linker-loader.c',
> >     'utils.c',
> > +  'erst.c',
> >   ))
> >   acpi_ss.add(when: 'CONFIG_ACPI_CPU_HOTPLUG', if_true: files('cpu.c'))
> >   acpi_ss.add(when: 'CONFIG_ACPI_CPU_HOTPLUG', if_true: files('cpu_hotplug.c'))