[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/6] python: AQMP-TUI Prototype

From: John Snow
Subject: Re: [PATCH v2 0/6] python: AQMP-TUI Prototype
Date: Wed, 21 Jul 2021 16:03:20 -0400

On Wed, Jul 21, 2021 at 2:09 PM Niteesh G. S. <niteesh.gs@gmail.com> wrote:
On Wed, Jul 21, 2021 at 12:39 AM John Snow <jsnow@redhat.com> wrote:
On Wed, Jul 14, 2021 at 3:07 PM Niteesh G. S. <niteesh.gs@gmail.com> wrote:

Why not?
I have already updated the status of this

Sorry, I missed this.

Thanks Niteesh, a few general comments that don't relate directly to the code:

1. It would be nice to be able to highlight/copy-paste things out of the history window, I seemingly can't right now.

2. It would be nice if the mouse scroll wheel worked on the history panel.

3. A greeting message like the old qmp-shell might be nice to see. It would be good if it explained how to quit the program (esc, ctrl^c) and send messages (alt+enter).

4. Some control hints or reminder text in the footer might be nice, for how to quit, send a message, etc.
I'll update the status here as I start working on them one by one.

OK - They don't need to go into this series, these are just some observations. All of these items seem like good candidates for standalone follow-up patches to happen in another series that follows this one.
For the next revision, I may ask you to start looking into making sure that mypy and pylint pass without exemptions. Do the best you can, and get as far as you are able. You can leave the warnings disabled for V3, but I'd like you to start taking a look now so that you know where the trouble spots are.

I'll be on PTO for the next three business days, returning 2021-07-27 -- If you get blocked on other tasks, try adding mypy type hints using this downtime.
Thanks again,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]