[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.1 0/1] machine: Disallow specifying topology parameters
Re: [PATCH for-6.1 0/1] machine: Disallow specifying topology parameters as zero
Thu, 22 Jul 2021 22:12:30 +0800
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0
On 2021/7/22 21:55, Paolo Bonzini wrote:
On 22/07/21 15:37, Andrew Jones wrote:
This doesn't mention zero inputs and even implies non-zero inputs.
I'm not sure if we need to worry about the odd command line that used
for some parameters. What do you think?
I think I agree as well, however the patch that Yanan sent has
unnecessary duplication between smp_parse and pc_smp_parse.
machine_set_smp is a better place to implement this kind of check.
The smp_parse and pc_smp_parse are going to be converted into a
generic parser, and the added sanity-check in this patch will also be
tested in an unit test. So is it probably better to keep the check in the
parser instead of the caller? The duplication will be eliminated anyway
when there is one single parser.
But I can also implement the check in machine_set_smp as you mentioned
if it's more reasonable and preferred. :)