[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH for-6.1 v4 0/1] machine: Disallow specifying topology parameters

From: Yanan Wang
Subject: [PATCH for-6.1 v4 0/1] machine: Disallow specifying topology parameters as zero
Date: Fri, 23 Jul 2021 15:31:21 +0800

In the SMP configuration, we should either specify a topology                   
parameter with a reasonable value (equal to or greater than 1)                  
or just leave it omitted and QEMU will calculate its value.                     
Configurations which explicitly specify the topology parameters                 
as zero like "sockets=0" are meaningless, so disallow them.                     
However; the commit 1e63fe685804d                                               
(machine: pass QAPI struct to mc->smp_parse) has documented that                
'0' has the same semantics as omitting a parameter in the qapi                  
comment for SMPConfiguration. So this patch fixes the doc and                   
also adds the corresponding sanity check in the smp parsers.                    
This patch originly comes form [1], and it was suggested that                   
this patch fixing the doc should be sent for 6.1 to avoid a                     
deprecation process in the future.                                              
[1] YPWsThPiZa3mF+zp@redhat.com/">https://lore.kernel.org/qemu-devel/YPWsThPiZa3mF+zp@redhat.com/             

- fix the typos
- v3: 
- improve the error message                                                     
- v2: 
- move the check to machine_set_smp                                             
- update qemu-option.hx                                                         
- v1: 

Yanan Wang (1):
  machine: Disallow specifying topology parameters as zero

 hw/core/machine.c | 15 +++++++++++++++
 qapi/machine.json |  6 +++---
 qemu-options.hx   | 12 +++++++-----
 3 files changed, 25 insertions(+), 8 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]