[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/22] target/loongarch: Add interrupt handling support
From: |
Song Gao |
Subject: |
Re: [PATCH v2 04/22] target/loongarch: Add interrupt handling support |
Date: |
Mon, 26 Jul 2021 17:23:47 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux mips64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Hi, Richard.
On 07/23/2021 06:47 AM, Richard Henderson wrote:
> On 7/20/21 11:53 PM, Song Gao wrote:
>> +bool loongarch_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
>> +{
>> + if (interrupt_request & CPU_INTERRUPT_HARD) {
>> + LoongArchCPU *cpu = LOONGARCH_CPU(cs);
>> + CPULoongArchState *env = &cpu->env;
>> +
>> + if (cpu_loongarch_hw_interrupts_enabled(env) &&
>> + cpu_loongarch_hw_interrupts_pending(env)) {
>> + cs->exception_index = EXCP_INTE;
>> + env->error_code = 0;
>> + loongarch_cpu_do_interrupt(cs);
>> + return true;
>> + }
>> + }
>> + return false;
>> +}
>
> Not sure what you're doing here, with user-only. None of these conditions
> apply.
>
OK, I'll remove it.
Thanks
Song Gao.