[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2] hw/acpi: some cosmetic improvements to existing code

From: Ani Sinha
Subject: [PATCH v2] hw/acpi: some cosmetic improvements to existing code
Date: Mon, 26 Jul 2021 18:22:09 +0530

All existing code using acpi_get_i386_pci_host() checks for a non-null
return from this function call. This change brings the same check to
acpi_pcihp_disable_root_bus() function.

Fixes: c0e427d6eb5fef ("hw/acpi/ich9: Enable ACPI PCI hot-plug")

Signed-off-by: Ani Sinha <ani@anisinha.ca>
 hw/acpi/pcihp.c | 5 +++++
 1 file changed, 5 insertions(+)

v1: initial patch
v2: removed comment addition - that can be sent as a separate patch.

diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
index f4d706e47d..856c6e1b47 100644
--- a/hw/acpi/pcihp.c
+++ b/hw/acpi/pcihp.c
@@ -136,6 +136,11 @@ static void acpi_pcihp_disable_root_bus(void)
+    if (!host) {
+        root_hp_disabled = true;
+        return;
+    }
     bus = PCI_HOST_BRIDGE(host)->bus;
     if (bus) {
         /* setting the hotplug handler to NULL makes the bus non-hotpluggable 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]