[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/9] memory: Introduce memory_region_transaction_{push|pop

From: David Hildenbrand
Subject: Re: [PATCH v2 3/9] memory: Introduce memory_region_transaction_{push|pop}()
Date: Tue, 27 Jul 2021 15:06:39 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 23.07.21 21:34, Peter Xu wrote:
memory_region_transaction_{begin|commit}() could be too big when finalizing a
memory region.  E.g., we should never attempt to update address space topology
during the finalize() of a memory region.  Provide helpers for further use.

Signed-off-by: Peter Xu <peterx@redhat.com>
  softmmu/memory.c | 14 ++++++++++++--
  1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/softmmu/memory.c b/softmmu/memory.c
index bfedaf9c4d..1a3e9ff8ad 100644
--- a/softmmu/memory.c
+++ b/softmmu/memory.c
@@ -1079,10 +1079,20 @@ static void address_space_update_topology(AddressSpace 
+static void memory_region_transaction_push(void)
+    memory_region_transaction_depth++;
+static void memory_region_transaction_pop(void)
+    memory_region_transaction_depth--;

push/pop has to me stack semantics, meaning we do more than just increment/decrement the depth.

I'd have used

memory_region_transaction_depth_inc() / memory_region_transaction_depth_dec()



David / dhildenb

reply via email to

[Prev in Thread] Current Thread [Next in Thread]