Re: [PATCH for-6.1? 4/6] job: Add job_cancel_requested()

[Max Reitz]

On 27.07.21 16:47, Vladimir Sementsov-Ogievskiy wrote:
> 26.07.2021 10:09, Max Reitz wrote:
> > > >           job->ret = -ECANCELED;
> > > >       }
> > > >       if (job->ret) {
> > > > @@ -704,7 +709,7 @@ static int job_finalize_single(Job *job)
> > > >         /* Emit events only if we actually started */
> > > >       if (job_started(job)) {
> > > > -        if (job_is_cancelled(job)) {
> > > > +        if (job_cancel_requested(job)) {
> > > >               job_event_cancelled(job);
> > >
> > > Same question here.. Shouldn't mirror report COMPLETED event in case 
> > > of not-force cancelled in READY state?
> >
> > Same here, I thought this is user-visible, nothing internal, so I 
> > should leave it as-is.
> >
> > Now I see that cancelling mirror post-READY indeed should result in a 
> > COMPLETED event.  So I’m actually not exactly sure how mirror does 
> > that, despite this code here
>
>
> Hmm. Now looking at mirror code, I see that it does 
> "s->common.job.cancelled = false"

*lol*, that’s nice.

So since we’ve missed the rc1 boat now, I think this is 6.2 material.  
I’ll look into whether we can drop that then, that would be nice.

Max