Re: [PATCH RFC server 04/11] vfio-user: find and init PCI device

[Jag Raman]

> On Jul 26, 2021, at 11:05 AM, John Levon <levon@movementarian.org> wrote:
> 
> On Mon, Jul 19, 2021 at 04:00:06PM -0400, Jagannathan Raman wrote:
> 
>> +    vfu_pci_set_id(o->vfu_ctx,
>> +                   pci_get_word(o->pci_dev->config + PCI_VENDOR_ID),
>> +                   pci_get_word(o->pci_dev->config + PCI_DEVICE_ID),
>> +                   pci_get_word(o->pci_dev->config + 
>> PCI_SUBSYSTEM_VENDOR_ID),
>> +                   pci_get_word(o->pci_dev->config + PCI_SUBSYSTEM_ID));
> 
> Since you handle all config space accesses yourselves, is there even any need
> for this?

I think that makes sense. Since the QEMU server handles all the config space
accesses, it’s not necessary to register the device’s vendor/device ID with the 
library.

Thank you!
--
Jag

> 
> regards
> john