[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 6/8] cpus: Remove the mutex parameter from do_run_on_cpu()
From: |
Peter Xu |
Subject: |
[PATCH v3 6/8] cpus: Remove the mutex parameter from do_run_on_cpu() |
Date: |
Wed, 28 Jul 2021 14:31:49 -0400 |
We must use the BQL for do_run_on_cpu() without much choice, it means the
parameter is useless. Remove it. Meanwhile use the newly introduced
qemu_cond_wait_iothread() in do_run_on_cpu().
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
softmmu/cpus.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/softmmu/cpus.c b/softmmu/cpus.c
index e714dfbf2b..9154cd7e78 100644
--- a/softmmu/cpus.c
+++ b/softmmu/cpus.c
@@ -383,8 +383,7 @@ void qemu_init_cpu_loop(void)
}
static void
-do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data,
- QemuMutex *mutex)
+do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data)
{
struct qemu_work_item wi = {
.func = func,
@@ -400,14 +399,14 @@ do_run_on_cpu(CPUState *cpu, run_on_cpu_func func,
run_on_cpu_data data,
while (!qatomic_mb_read(&wi.done)) {
CPUState *self_cpu = current_cpu;
- qemu_cond_wait(&qemu_work_cond, mutex);
+ qemu_cond_wait_iothread(&qemu_work_cond);
current_cpu = self_cpu;
}
}
void run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data)
{
- do_run_on_cpu(cpu, func, data, &qemu_global_mutex);
+ do_run_on_cpu(cpu, func, data);
}
static void qemu_cpu_stop(CPUState *cpu, bool exit)
--
2.31.1
- [PATCH v3 0/8] memory: Sanity checks memory transaction when releasing BQL, Peter Xu, 2021/07/28
- [PATCH v3 1/8] cpus: Export queue work related fields to cpu.h, Peter Xu, 2021/07/28
- [PATCH v3 3/8] memory: Introduce memory_region_transaction_depth_{inc|dec}(), Peter Xu, 2021/07/28
- [PATCH v3 2/8] cpus: Move do_run_on_cpu into softmmu/cpus.c, Peter Xu, 2021/07/28
- [PATCH v3 4/8] memory: Don't do topology update in memory finalize(), Peter Xu, 2021/07/28
- [PATCH v3 5/8] cpus: Use qemu_cond_wait_iothread() where proper, Peter Xu, 2021/07/28
- [PATCH v3 6/8] cpus: Remove the mutex parameter from do_run_on_cpu(),
Peter Xu <=
- [PATCH v3 8/8] memory: Delay the transaction pop() until commit completed, Peter Xu, 2021/07/28
- [PATCH v3 7/8] memory: Assert on no ongoing memory transaction before release BQL, Peter Xu, 2021/07/28