[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.2 v3 09/11] machine: Make smp_parse generic enough for
|
From: |
Andrew Jones |
|
Subject: |
Re: [PATCH for-6.2 v3 09/11] machine: Make smp_parse generic enough for all arches |
|
Date: |
Wed, 28 Jul 2021 22:41:35 +0200 |
On Wed, Jul 28, 2021 at 10:38:57PM +0200, Andrew Jones wrote:
> On Wed, Jul 28, 2021 at 11:48:46AM +0800, Yanan Wang wrote:
> > @@ -248,6 +256,7 @@ struct MachineClass {
> > bool numa_mem_supported;
> > bool auto_enable_numa;
> > bool smp_prefer_sockets;
> > + SMPCompatProps smp_props;
> > const char *default_ram_id;
> >
> > HotplugHandler *(*get_hotplug_handler)(MachineState *machine,
> > --
> > 2.19.1
> >
>
> What about putting smp_prefer_sockets in SMPCompatProps too (as
> prefer_sockets)?
Ah, I see patch 11/11 does that.
Thanks,
drew
>
> Otherwise
>
> Reviewed-by: Andrew Jones <drjones@redhat.com>
- [PATCH for-6.2 v3 04/11] machine: Improve the error reporting of smp parsing, (continued)
- [PATCH for-6.2 v3 04/11] machine: Improve the error reporting of smp parsing, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 02/11] machine: Uniformly use maxcpus to calculate the omitted parameters, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 07/11] machine: Use ms instead of global current_machine in sanity-check, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 10/11] machine: Remove smp_parse callback from MachineClass, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 09/11] machine: Make smp_parse generic enough for all arches, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 03/11] machine: Set the value of cpus to match maxcpus if it's omitted, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 06/11] machine: Prefer cores over sockets in smp parsing since 6.2, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 11/11] machine: Move smp_prefer_sockets to struct SMPCompatProps, Yanan Wang, 2021/07/27