[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: Fix migration-test build failure for sparc

From: Richard Henderson
Subject: Re: [PATCH] tests: Fix migration-test build failure for sparc
Date: Wed, 28 Jul 2021 13:05:36 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 7/28/21 11:41 AM, Peter Xu wrote:
Even if <linux/kvm.h> seems to exist for all archs on linux, however including
it with __linux__ defined seems to be not working yet as it'll try to include
asm/kvm.h and that can be missing for archs that do not support kvm.

To fix this (instead of any attempt to fix linux headers..), we can mark the
header to be x86_64 only, because it's so far only service for adding the kvm
dirty ring test.

No need to have "Fixes" as the issue is just introduced very recently.

What an odd thing to say.  How do I know that without the link?
Fixes: 1f546b709d61

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


Reported-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Peter Xu <peterx@redhat.com>
  tests/qtest/migration-test.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 1e8b7784ef..cc5e83d98a 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -27,7 +27,8 @@
  #include "migration-helpers.h"
  #include "tests/migration/migration-test.h"
-#if defined(__linux__)
+/* For dirty ring test; so far only x86_64 is supported */
+#if defined(__linux__) && defined(HOST_X86_64)
  #include "linux/kvm.h"
@@ -1395,7 +1396,7 @@ static void test_multifd_tcp_cancel(void) static bool kvm_dirty_ring_supported(void)
-#if defined(__linux__)
+#if defined(__linux__) && defined(HOST_X86_64)
      int ret, kvm_fd = open("/dev/kvm", O_RDONLY);
if (kvm_fd < 0) {

reply via email to

[Prev in Thread] Current Thread [Next in Thread]