RE: [PATCH 4/4] docs/system: Add a64fx(Fujitsu A64FX processor) to supported guest CPU type

[address@hidden]

Hi, Peter.

> This adds a64fx to the list of CPUs we support in the 'virt' board, but it 
> hasn't
> changed the valid_cpus[] array in hw/arm/virt.c, so trying to actually use 
> -cpu
> a64fx with -machine virt will fail.

I'm sorry, but just to be sure, let me check.

Is it correct to understand that the above comment means that we need to add
the following fixes included in "[PATCH 2/4] target-arm: cpu64: Add support for 
Fujitsu A64FX" patch
within this patch to make it a meaningful fix within one patch?

> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 93ab9d2..2e91991 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -202,6 +202,7 @@ static const char *valid_cpus[] = {
> ARM_CPU_TYPE_NAME("cortex-a72"),
> ARM_CPU_TYPE_NAME("host"),
> ARM_CPU_TYPE_NAME("max"),
> + ARM_CPU_TYPE_NAME("a64fx"),
> };

Best regards.

> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Monday, July 19, 2021 9:56 PM
> To: ishii.shuuichir@fujitsu.com
> Cc: Thomas Huth <thuth@redhat.com>; Laurent Vivier <lvivier@redhat.com>;
> Paolo Bonzini <pbonzini@redhat.com>; qemu-arm <qemu-arm@nongnu.org>;
> QEMU Developers <qemu-devel@nongnu.org>
> Subject: Re: [PATCH 4/4] docs/system: Add a64fx(Fujitsu A64FX processor) to
> supported guest CPU type
> 
> On Fri, 16 Jul 2021 at 06:27, Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
> wrote:
> >
> > Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
> > ---
> >  docs/system/arm/virt.rst | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/docs/system/arm/virt.rst b/docs/system/arm/virt.rst index
> > 27652ad..5329e95 100644
> > --- a/docs/system/arm/virt.rst
> > +++ b/docs/system/arm/virt.rst
> > @@ -55,6 +55,7 @@ Supported guest CPU types:
> >  - ``cortex-a53`` (64-bit)
> >  - ``cortex-a57`` (64-bit)
> >  - ``cortex-a72`` (64-bit)
> > +- ``a64fx`` (64-bit)
> >  - ``host`` (with KVM only)
> >  - ``max`` (same as ``host`` for KVM; best possible emulation with
> > TCG)
> 
> This adds a64fx to the list of CPUs we support in the 'virt' board, but it 
> hasn't
> changed the valid_cpus[] array in hw/arm/virt.c, so trying to actually use 
> -cpu
> a64fx with -machine virt will fail.
> 
> thanks
> -- PMM