[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/9] gitlab-ci: Fix 'when:' condition in EDK2 jobs
From: |
Thomas Huth |
Subject: |
[PULL 3/9] gitlab-ci: Fix 'when:' condition in EDK2 jobs |
Date: |
Thu, 29 Jul 2021 10:22:05 +0200 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Jobs depending on another should not use the 'when: always'
condition, because if a dependency failed we should not keep
running jobs depending on it. The correct condition is
'when: on_success'.
Fixes: 71920809cea ("gitlab-ci.yml: Add jobs to build EDK2 firmware binaries")
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210727142431.1672530-4-philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
.gitlab-ci.d/edk2.yml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/.gitlab-ci.d/edk2.yml b/.gitlab-ci.d/edk2.yml
index aae2f7ad88..62497ba47f 100644
--- a/.gitlab-ci.d/edk2.yml
+++ b/.gitlab-ci.d/edk2.yml
@@ -8,11 +8,11 @@
- .gitlab-ci.d/edk2/Dockerfile
# or roms/edk2/ is modified (submodule updated)
- roms/edk2/*
- when: always
+ when: on_success
- if: '$CI_COMMIT_REF_NAME =~ /^edk2/' # or the branch/tag starts with 'edk2'
- when: always
+ when: on_success
- if: '$CI_COMMIT_MESSAGE =~ /edk2/i' # or last commit description contains
'EDK2'
- when: always
+ when: on_success
docker-edk2:
extends: .edk2_job_rules
--
2.27.0
- [PULL 0/9] Gitlab-CI improvements and some other fixes, Thomas Huth, 2021/07/29
- [PULL 1/9] docs: Document GitLab custom CI/CD variables, Thomas Huth, 2021/07/29
- [PULL 2/9] gitlab-ci: Fix 'when:' condition in acceptance_test_job_template, Thomas Huth, 2021/07/29
- [PULL 3/9] gitlab-ci: Fix 'when:' condition in EDK2 jobs,
Thomas Huth <=
- [PULL 4/9] gitlab-ci: Fix 'when:' condition in OpenSBI jobs, Thomas Huth, 2021/07/29
- [PULL 5/9] gitlab-ci.d/buildtest: Disable iotests 197 and 215, Thomas Huth, 2021/07/29
- [PULL 6/9] gitlab-ci.d/buildtest: Mark the aarch64 and ppc64-s390x CFI jobs as manual, Thomas Huth, 2021/07/29
- [PULL 7/9] gitlab-ci.d/custom-runners: Improve rules for the staging branch, Thomas Huth, 2021/07/29
- [PULL 8/9] tests: Fix migration-test build failure for sparc, Thomas Huth, 2021/07/29
- [PULL 9/9] configure script fix for Haiku, Thomas Huth, 2021/07/29
- Re: [PULL 0/9] Gitlab-CI improvements and some other fixes, Peter Maydell, 2021/07/29