[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproje
From: |
Peter Maydell |
Subject: |
Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject |
Date: |
Thu, 29 Jul 2021 13:58:06 +0100 |
On Thu, 29 Jul 2021 at 13:56, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Meson now checks that subprojects do not access files from parent
> project. While we all agree this is best practice, libvhost-user also
> want to share a few headers with QEMU, and libvhost-user isn't really a
> standalone project at this point (although this is making the dependency
> a bit more explicit).
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Message-Id: <20210505151313.203258-1-marcandre.lureau@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> subprojects/libvhost-user/include/atomic.h | 1 +
> subprojects/libvhost-user/libvhost-user.c | 2 +-
> subprojects/libvhost-user/meson.build | 6 +-----
> subprojects/libvhost-user/standard-headers/linux | 1 +
> diff --git a/subprojects/libvhost-user/include/atomic.h
> b/subprojects/libvhost-user/include/atomic.h
> new file mode 120000
> index 0000000000..8c2be64f7b
> --- /dev/null
> +++ b/subprojects/libvhost-user/include/atomic.h
> @@ -0,0 +1 @@
> +../../../include/qemu/atomic.h
> \ No newline at end of file
> diff --git a/subprojects/libvhost-user/standard-headers/linux
> b/subprojects/libvhost-user/standard-headers/linux
> new file mode 120000
> index 0000000000..15a2378139
> --- /dev/null
> +++ b/subprojects/libvhost-user/standard-headers/linux
> @@ -0,0 +1 @@
> +../../../include/standard-headers/linux
> \ No newline at end of file
Should these really be missing the trailing newline ?
-- PMM
- [PULL 0/7] Misc patches for QEMU 6.1-rc2, Paolo Bonzini, 2021/07/29
- [PULL 1/7] i386: assert 'cs->kvm_state' is not null, Paolo Bonzini, 2021/07/29
- [PULL 2/7] Makefile: ignore long options, Paolo Bonzini, 2021/07/29
- [PULL 3/7] configure: Add -Werror to avx2, avx512 tests, Paolo Bonzini, 2021/07/29
- [PULL 4/7] target/i386: Added consistency checks for event injection, Paolo Bonzini, 2021/07/29
- [PULL 5/7] target/i386: fix typo in ctl_has_irq, Paolo Bonzini, 2021/07/29
- [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject, Paolo Bonzini, 2021/07/29
- Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject,
Peter Maydell <=
[PULL 7/7] libvhost-user: fix -Werror=format= warnings with __u64 fields, Paolo Bonzini, 2021/07/29
Re: [PULL 0/7] Misc patches for QEMU 6.1-rc2, Peter Maydell, 2021/07/29