[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-6.2 05/43] target/microblaze: Implement do_unaligned_acce

From: Richard Henderson
Subject: Re: [PATCH for-6.2 05/43] target/microblaze: Implement do_unaligned_access for user-only
Date: Thu, 29 Jul 2021 08:00:50 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 7/29/21 3:26 AM, Peter Maydell wrote:
On Thu, 29 Jul 2021 at 01:54, Richard Henderson
<richard.henderson@linaro.org> wrote:

Cc: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
  target/microblaze/cpu.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c
index 72d8f2a0da..cbec062ed7 100644
--- a/target/microblaze/cpu.c
+++ b/target/microblaze/cpu.c
@@ -367,11 +367,11 @@ static const struct TCGCPUOps mb_tcg_ops = {
      .synchronize_from_tb = mb_cpu_synchronize_from_tb,
      .cpu_exec_interrupt = mb_cpu_exec_interrupt,
      .tlb_fill = mb_cpu_tlb_fill,
+    .do_unaligned_access = mb_cpu_do_unaligned_access,

      .do_interrupt = mb_cpu_do_interrupt,
      .do_transaction_failed = mb_cpu_transaction_failed,
-    .do_unaligned_access = mb_cpu_do_unaligned_access,
  #endif /* !CONFIG_USER_ONLY */

If I'm reading the kernel sources correctly, for Microblaze it always
fixes up unaligned accesses, so for our linux-user code we want
"ignore unaligned access errors" rather than reporting them up
to cpu-loop.c, I think ?

Ah, in that case we should not be setting MO_ALIGN for some -cpu xxx, I think? Or does the MSR_EE bit cover that? Anyway, it looked reachable at first glance.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]