Re: [PATCH 1/3] ui/gtk: adds status bar for expressing ups and fps

[Eric Blake]

On Mon, Jul 26, 2021 at 03:25:49PM -0700, Dongwon Kim wrote:

[meta-comment] When sending a patch series, remember to include a 0/3
cover letter, as it makes it easier to distinguish replies about the
series as a whole from review of the first patch.

> With a display option, "show-fps=on", qemu adds a status bar and print
> following performance numbers on the bar,
> 
> ups = update per seconds - the rate the guest scanout is updated.
> fps = frame per seconds - the frame rate of VC's GL drawing area
> 
> One function, gd_gl_count_frame is added to count # frames
> and calculate ups and fps every 100 frames or guest scanout updates.
> 
> Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
> ---
>  include/ui/console.h |  4 +++-
>  include/ui/gtk.h     |  2 ++
>  qapi/ui.json         |  6 +++++-
>  ui/console.c         |  6 ++++++
>  ui/gtk.c             | 51 ++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 67 insertions(+), 2 deletions(-)

> +++ b/qapi/ui.json
> @@ -1035,13 +1035,17 @@
>  #               assuming the guest will resize the display to match
>  #               the window size then.  Otherwise it defaults to "off".
>  #               Since 3.1
> +# @show-fps:    Enable showing Guest Scanout's update rate (UPS) and
> +#               Surface render swap rate (FPS) on a status bar (default: 
> off).
> +#               Since 6.0

This is too late to make the 6.1 release; at best, it should read
'since 6.2'

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org