[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.2 06/10] docs: qom: Remove unnecessary class typedefs f
From: |
Markus Armbruster |
Subject: |
Re: [PATCH for-6.2 06/10] docs: qom: Remove unnecessary class typedefs from example |
Date: |
Fri, 30 Jul 2021 10:16:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Eduardo Habkost <ehabkost@redhat.com> writes:
> When there's no specific class struct used for a QOM type, we
> normally don't define a typedef for it. Remove the typedef from
> the minimal example, as it is unnecessary.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> docs/devel/qom.rst | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst
> index 05d045bf570..dee60a64c0a 100644
> --- a/docs/devel/qom.rst
> +++ b/docs/devel/qom.rst
> @@ -20,9 +20,6 @@ features:
>
> #define TYPE_MY_DEVICE "my-device"
>
> - // No new virtual functions: we can reuse the typedef for the
> - // superclass.
> - typedef DeviceClass MyDeviceClass;
> typedef struct MyDevice
> {
> DeviceState parent;
Documenting existing practice makes sense, but I'm not sure the existing
practice to elide this typedef makes sense.
- [PATCH for-6.2 00/10] QOM documentation updates, Eduardo Habkost, 2021/07/29
- [PATCH for-6.2 03/10] docs: qom: Fix autoptr expansion example, Eduardo Habkost, 2021/07/29
- [PATCH for-6.2 04/10] docs: qom: Fix "API Reference" heading level, Eduardo Habkost, 2021/07/29
- [PATCH for-6.2 02/10] docs: qom: Use Sphinx cross references more often, Eduardo Habkost, 2021/07/29
- [PATCH for-6.2 01/10] docs: qom: Replace old GTK-Doc #symbol syntax with `symbol`, Eduardo Habkost, 2021/07/29
- [PATCH for-6.2 05/10] docs: qom: Add subsection headings to declaration/definition macros section, Eduardo Habkost, 2021/07/29
- [PATCH for-6.2 06/10] docs: qom: Remove unnecessary class typedefs from example, Eduardo Habkost, 2021/07/29
- Re: [PATCH for-6.2 06/10] docs: qom: Remove unnecessary class typedefs from example,
Markus Armbruster <=
- [PATCH for-6.2 07/10] docs: qom: Fix OBJECT_DECLARE_SIMPLE_TYPE documentation, Eduardo Habkost, 2021/07/29
- [PATCH for-6.2 09/10] docs: qom: Remove OBJECT_CHECK macro examples, Eduardo Habkost, 2021/07/29
- [PATCH for-6.2 08/10] docs: qom: Show actual typecast functions in examples, Eduardo Habkost, 2021/07/29
- [PATCH for-6.2 10/10] MAINTAINERS: Add qom.rst to QOM section, Eduardo Habkost, 2021/07/29