[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 04/13] plugins/hotblocks: Added correct boolean argument parsi
From: |
Mahmoud Mandour |
Subject: |
[PATCH v4 04/13] plugins/hotblocks: Added correct boolean argument parsing |
Date: |
Fri, 30 Jul 2021 15:58:08 +0200 |
Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
---
contrib/plugins/hotblocks.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c
index 4b08340143..062200a7a4 100644
--- a/contrib/plugins/hotblocks.c
+++ b/contrib/plugins/hotblocks.c
@@ -133,8 +133,18 @@ QEMU_PLUGIN_EXPORT
int qemu_plugin_install(qemu_plugin_id_t id, const qemu_info_t *info,
int argc, char **argv)
{
- if (argc && strcmp(argv[0], "inline") == 0) {
- do_inline = true;
+ for (int i = 0; i < argc; i++) {
+ char *opt = argv[i];
+ g_autofree char **tokens = g_strsplit(opt, "=", 2);
+ if (g_strcmp0(tokens[0], "inline") == 0) {
+ if (!qemu_plugin_bool_parse(tokens[0], tokens[1], &do_inline)) {
+ fprintf(stderr, "boolean argument parsing failed: %s\n", opt);
+ return -1;
+ }
+ } else {
+ fprintf(stderr, "option parsing failed: %s\n", opt);
+ return -1;
+ }
}
plugin_init();
--
2.25.1
- [PATCH v4 00/13] new plugin argument passing scheme, Mahmoud Mandour, 2021/07/30
- [PATCH v4 01/13] plugins: allow plugin arguments to be passed directly, Mahmoud Mandour, 2021/07/30
- [PATCH v4 02/13] plugins/api: added a boolean parsing plugin api, Mahmoud Mandour, 2021/07/30
- [PATCH v4 03/13] plugins/hotpages: introduce sortby arg and parsed bool args correctly, Mahmoud Mandour, 2021/07/30
- [PATCH v4 04/13] plugins/hotblocks: Added correct boolean argument parsing,
Mahmoud Mandour <=
- [PATCH v4 05/13] plugins/lockstep: make socket path not positional & parse bool arg, Mahmoud Mandour, 2021/07/30
- [PATCH v4 06/13] plugins/hwprofile: adapt to the new plugin arguments scheme, Mahmoud Mandour, 2021/07/30
- [PATCH v4 07/13] plugins/howvec: adapting to the new argument passing scheme, Mahmoud Mandour, 2021/07/30
- [PATCH v4 08/13] docs/tcg-plugins: new passing parameters scheme for cache docs, Mahmoud Mandour, 2021/07/30
- [PATCH v4 09/13] tests/plugins/bb: adapt to the new arg passing scheme, Mahmoud Mandour, 2021/07/30
- [PATCH v4 10/13] tests/plugins/insn: made arg inline not positional and parse it as bool, Mahmoud Mandour, 2021/07/30
- [PATCH v4 11/13] tests/plugins/mem: introduce "track" arg and make args not positional, Mahmoud Mandour, 2021/07/30
- [PATCH v4 12/13] tests/plugins/syscalls: adhere to new arg-passing scheme, Mahmoud Mandour, 2021/07/30
- [PATCH v4 13/13] docs/deprecated: deprecate passing plugin args through `arg=`, Mahmoud Mandour, 2021/07/30