[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/5] hw/net: e1000e: Don't zero out the VLAN tag in the legacy RX
From: |
Jason Wang |
Subject: |
[PULL 5/5] hw/net: e1000e: Don't zero out the VLAN tag in the legacy RX descriptor |
Date: |
Mon, 2 Aug 2021 12:33:44 +0800 |
From: Christina Wang <christina.wang@windriver.com>
In the legacy RX descriptor mode, VLAN tag was saved to d->special
by e1000e_build_rx_metadata() in e1000e_write_lgcy_rx_descr(), but
it was then zeroed out again at the end of the call, which is wrong.
Fixes: c89d416a2b0f ("e1000e: Don't zero out buffer address in rx descriptor")
Reported-by: Markus Carlstedt <markus.carlstedt@windriver.com>
Signed-off-by: Christina Wang <christina.wang@windriver.com>
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/net/e1000e_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index b4bf4ca..8ae6fb7 100644
--- a/hw/net/e1000e_core.c
+++ b/hw/net/e1000e_core.c
@@ -1285,7 +1285,6 @@ e1000e_write_lgcy_rx_descr(E1000ECore *core, uint8_t
*desc,
&d->special);
d->errors = (uint8_t) (le32_to_cpu(status_flags) >> 24);
d->status = (uint8_t) le32_to_cpu(status_flags);
- d->special = 0;
}
static inline void
--
2.7.4
- [PULL 0/5] Net patches, Jason Wang, 2021/08/02
- [PULL 1/5] hw/net/vmxnet3: Do not abort QEMU if guest specified bad queue numbers, Jason Wang, 2021/08/02
- [PULL 2/5] hw/net/can: sja1000 fix buff2frame_bas and buff2frame_pel when dlc is out of std CAN 8 bytes, Jason Wang, 2021/08/02
- [PULL 3/5] hw/net: e1000: Correct the initial value of VET register, Jason Wang, 2021/08/02
- [PULL 4/5] hw/net: e1000e: Correct the initial value of VET register, Jason Wang, 2021/08/02
- [PULL 5/5] hw/net: e1000e: Don't zero out the VLAN tag in the legacy RX descriptor,
Jason Wang <=
- Re: [PULL 0/5] Net patches, Peter Maydell, 2021/08/02