[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/8] coverity-model: remove model for more allocation functions
From: |
Paolo Bonzini |
Subject: |
[PULL 5/8] coverity-model: remove model for more allocation functions |
Date: |
Mon, 2 Aug 2021 18:15:39 +0200 |
These models are not needed anymore now that Coverity does not check
anymore that the result is used with "g_free". Coverity understands
GCC attributes and uses them to detect leaks.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
scripts/coverity-scan/model.c | 105 +---------------------------------
1 file changed, 1 insertion(+), 104 deletions(-)
diff --git a/scripts/coverity-scan/model.c b/scripts/coverity-scan/model.c
index 8e64a84c5a..1a5f39d2ae 100644
--- a/scripts/coverity-scan/model.c
+++ b/scripts/coverity-scan/model.c
@@ -263,7 +263,7 @@ void *g_try_realloc_n(void *ptr, size_t nmemb, size_t size)
return g_realloc_n(ptr, nmemb, size);
}
-/* Trivially derive the g_FOO() from the g_FOO_n() */
+/* Derive the g_FOO() from the g_FOO_n() */
void *g_malloc(size_t size)
{
@@ -295,109 +295,6 @@ void *g_try_realloc(void *ptr, size_t size)
return g_try_realloc_n(ptr, 1, size);
}
-/* Other memory allocation functions */
-
-void *g_memdup(const void *ptr, unsigned size)
-{
- unsigned char *dup;
- unsigned i;
-
- if (!ptr) {
- return NULL;
- }
-
- dup = g_malloc(size);
- for (i = 0; i < size; i++)
- dup[i] = ((unsigned char *)ptr)[i];
- return dup;
-}
-
-/*
- * GLib string allocation functions
- */
-
-char *g_strdup(const char *s)
-{
- char *dup;
- size_t i;
-
- if (!s) {
- return NULL;
- }
-
- __coverity_string_null_sink__(s);
- __coverity_string_size_sink__(s);
- dup = __coverity_alloc_nosize__();
- __coverity_mark_as_afm_allocated__(dup, AFM_free);
- for (i = 0; (dup[i] = s[i]); i++) ;
- return dup;
-}
-
-char *g_strndup(const char *s, size_t n)
-{
- char *dup;
- size_t i;
-
- __coverity_negative_sink__(n);
-
- if (!s) {
- return NULL;
- }
-
- dup = g_malloc(n + 1);
- for (i = 0; i < n && (dup[i] = s[i]); i++) ;
- dup[i] = 0;
- return dup;
-}
-
-char *g_strdup_printf(const char *format, ...)
-{
- char ch, *s;
- size_t len;
-
- __coverity_string_null_sink__(format);
- __coverity_string_size_sink__(format);
-
- ch = *format;
-
- s = __coverity_alloc_nosize__();
- __coverity_writeall__(s);
- __coverity_mark_as_afm_allocated__(s, AFM_free);
- return s;
-}
-
-char *g_strdup_vprintf(const char *format, va_list ap)
-{
- char ch, *s;
- size_t len;
-
- __coverity_string_null_sink__(format);
- __coverity_string_size_sink__(format);
-
- ch = *format;
-
- s = __coverity_alloc_nosize__();
- __coverity_writeall__(s);
- __coverity_mark_as_afm_allocated__(s, AFM_free);
-
- return len;
-}
-
-char *g_strconcat(const char *s, ...)
-{
- char *s;
-
- /*
- * Can't model: last argument must be null, the others
- * null-terminated strings
- */
-
- s = __coverity_alloc_nosize__();
- __coverity_writeall__(s);
- __coverity_mark_as_afm_allocated__(s, AFM_free);
- return s;
-}
-
/* Other glib functions */
typedef struct pollfd GPollFD;
--
2.31.1
- [PULL 0/8] vl.c, coverity patches for QEMU 6.1-rc2, Paolo Bonzini, 2021/08/02
- [PULL 4/8] coverity-model: make g_free a synonym of free, Paolo Bonzini, 2021/08/02
- [PULL 3/8] coverity-model: update address_space_read/write models, Paolo Bonzini, 2021/08/02
- [PULL 5/8] coverity-model: remove model for more allocation functions,
Paolo Bonzini <=
- [PULL 7/8] coverity-model: constrain g_malloc/g_malloc0/g_realloc as never returning NULL, Paolo Bonzini, 2021/08/02
- [PULL 6/8] coverity-model: clean up the models for array allocation functions, Paolo Bonzini, 2021/08/02
- [PULL 2/8] vl: stop recording -smp in QemuOpts, Paolo Bonzini, 2021/08/02
- [PULL 1/8] vl: introduce machine_merge_property, Paolo Bonzini, 2021/08/02
- [PULL 8/8] coverity-model: write models fully for non-array allocation functions, Paolo Bonzini, 2021/08/02
- Re: [PULL 0/8] vl.c, coverity patches for QEMU 6.1-rc2, Peter Maydell, 2021/08/02