RE: [PATCH v2 3/3] target-arm: Add A64FX processor support to virt machine

[address@hidden]

> Commit messages should describe what the patch is doing and why, so the reader
> can understand it without having to cross-reference old mailing list threads.

Thank you for your comment.
I understood your point.

Best regards.
> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Friday, July 30, 2021 7:36 PM
> To: Ishii, Shuuichirou <ishii.shuuichir@fujitsu.com>
> Cc: qemu-arm <qemu-arm@nongnu.org>; QEMU Developers
> <qemu-devel@nongnu.org>
> Subject: Re: [PATCH v2 3/3] target-arm: Add A64FX processor support to virt
> machine
> 
> On Fri, 30 Jul 2021 at 04:08, Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
> wrote:
> >
> > Fix for patch consistency.
> > https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg06993.html
> 
> Commit messages should describe what the patch is doing and why, so the reader
> can understand it without having to cross-reference old mailing list threads.
> 
> > Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
> > ---
> >  docs/system/arm/virt.rst | 1 +
> >  hw/arm/virt.c            | 1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/docs/system/arm/virt.rst b/docs/system/arm/virt.rst index
> > 27652adfae..5329e952cf 100644
> > --- a/docs/system/arm/virt.rst
> > +++ b/docs/system/arm/virt.rst
> > @@ -55,6 +55,7 @@ Supported guest CPU types:
> >  - ``cortex-a53`` (64-bit)
> >  - ``cortex-a57`` (64-bit)
> >  - ``cortex-a72`` (64-bit)
> > +- ``a64fx`` (64-bit)
> >  - ``host`` (with KVM only)
> >  - ``max`` (same as ``host`` for KVM; best possible emulation with
> > TCG)
> >
> > diff --git a/hw/arm/virt.c b/hw/arm/virt.c index
> > 81eda46b0b..10286d3fd6 100644
> > --- a/hw/arm/virt.c
> > +++ b/hw/arm/virt.c
> > @@ -200,6 +200,7 @@ static const char *valid_cpus[] = {
> >      ARM_CPU_TYPE_NAME("cortex-a53"),
> >      ARM_CPU_TYPE_NAME("cortex-a57"),
> >      ARM_CPU_TYPE_NAME("cortex-a72"),
> > +    ARM_CPU_TYPE_NAME("a64fx"),
> >      ARM_CPU_TYPE_NAME("host"),
> >      ARM_CPU_TYPE_NAME("max"),
> >  };
> 
> thanks
> -- PMM