[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 03/33] qdev-properties: PropertyInfo: add realized_set_allowed
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v7 03/33] qdev-properties: PropertyInfo: add realized_set_allowed field |
Date: |
Wed, 4 Aug 2021 12:37:43 +0300 |
Add field, so property can declare support for setting the property
when device is realized. To be used in the following commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
include/hw/qdev-properties.h | 1 +
hw/core/qdev-properties.c | 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 0ef97d60ce..f7925f67d0 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -32,6 +32,7 @@ struct PropertyInfo {
const char *name;
const char *description;
const QEnumLookup *enum_table;
+ bool realized_set_allowed; /* allow setting property on realized device */
int (*print)(Object *obj, Property *prop, char *dest, size_t len);
void (*set_default_value)(ObjectProperty *op, const Property *prop);
ObjectProperty *(*create)(ObjectClass *oc, const char *name,
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 50f40949f5..c34aac6ebc 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -26,11 +26,11 @@ void qdev_prop_set_after_realize(DeviceState *dev, const
char *name,
/* returns: true if property is allowed to be set, false otherwise */
static bool qdev_prop_allow_set(Object *obj, const char *name,
- Error **errp)
+ const PropertyInfo *info, Error **errp)
{
DeviceState *dev = DEVICE(obj);
- if (dev->realized) {
+ if (dev->realized && !info->realized_set_allowed) {
qdev_prop_set_after_realize(dev, name, errp);
return false;
}
@@ -79,7 +79,7 @@ static void field_prop_set(Object *obj, Visitor *v, const
char *name,
{
Property *prop = opaque;
- if (!qdev_prop_allow_set(obj, name, errp)) {
+ if (!qdev_prop_allow_set(obj, name, prop->info, errp)) {
return;
}
--
2.29.2
- [PATCH v7 00/33] block: publish backup-top filter, Vladimir Sementsov-Ogievskiy, 2021/08/04
- [PATCH v7 01/33] block: introduce bdrv_replace_child_bs(), Vladimir Sementsov-Ogievskiy, 2021/08/04
- [PATCH v7 02/33] block: introduce blk_replace_bs, Vladimir Sementsov-Ogievskiy, 2021/08/04
- [PATCH v7 05/33] block: rename backup-top to copy-before-write, Vladimir Sementsov-Ogievskiy, 2021/08/04
- [PATCH v7 03/33] qdev-properties: PropertyInfo: add realized_set_allowed field,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v7 06/33] block-copy: move detecting fleecing scheme to block-copy, Vladimir Sementsov-Ogievskiy, 2021/08/04
- [PATCH v7 07/33] block/block-copy: introduce block_copy_set_copy_opts(), Vladimir Sementsov-Ogievskiy, 2021/08/04
- [PATCH v7 10/33] block/copy-before-write: relax permission requirements when no parents, Vladimir Sementsov-Ogievskiy, 2021/08/04
- [PATCH v7 08/33] block/backup: set copy_range and compress after filter insertion, Vladimir Sementsov-Ogievskiy, 2021/08/04
- [PATCH v7 11/33] block/copy-before-write: drop extra bdrv_unref on failure path, Vladimir Sementsov-Ogievskiy, 2021/08/04