[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v0 2/2] ppc,spapr: Handle KVM_EXIT_ESN
From: |
Laurent Vivier |
Subject: |
Re: [RFC PATCH v0 2/2] ppc,spapr: Handle KVM_EXIT_ESN |
Date: |
Thu, 5 Aug 2021 09:48:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 05/08/2021 09:32, Bharata B Rao wrote:
> Handle KVM_EXIT_ESN exit by issuing subvention notification
> interrupt to the guest. Guests supporting async-pf feature
> will need this interrupt to wake up tasks that are waiting
> for the expropriated pages to be available.
>
> Note: Updates to linux-headers/linux/kvm.h are temporary
> pending headers update.
>
> Signed-off-by: Bharata B Rao <bharata@linux.ibm.com>
> ---
> linux-headers/linux/kvm.h | 1 +
> target/ppc/kvm.c | 16 ++++++++++++++++
> 2 files changed, 17 insertions(+)
...
> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> index 330985c8a0..6bf3f06b88 100644
> --- a/target/ppc/kvm.c
> +++ b/target/ppc/kvm.c
...
> @@ -1657,6 +1658,16 @@ static int kvm_handle_debug(PowerPCCPU *cpu, struct
> kvm_run *run)
> return DEBUG_RETURN_GUEST;
> }
>
> +#if defined(TARGET_PPC64)
> +static void kvmppc_handle_esn(PowerPCCPU *cpu)
> +{
> + SpaprMachineState *spapr = SPAPR_MACHINE(qdev_get_machine());
> +
> + fprintf(stderr, "%s: ESN exit\n", __func__);
Do you keep this fprintf() on purpose?
You should use trace framework to add debugging traces.
Thanks,
Laurent