qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-6.2 1/2] disas/nios2: Fix style in print_insn_nios2()


From: Thomas Huth
Subject: Re: [PATCH-for-6.2 1/2] disas/nios2: Fix style in print_insn_nios2()
Date: Mon, 9 Aug 2021 08:08:09 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0

On 07/08/2021 13.09, Philippe Mathieu-Daudé wrote:
We are going to modify this function, fix its style first.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
  disas/nios2.c | 53 +++++++++++++++++++++++++--------------------------
  1 file changed, 26 insertions(+), 27 deletions(-)

I guess it'd make sense to either re-indent the whole file or to bite the bullet and life with the checkpatch warnings here ... otherwise you now have one function that matches the QEMU coding style while the rest of the file looks completely different.

OTOH, we still can clean that up later, so in case you want to keep this patch:

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]