[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] ps2: use a separate keyboard command reply queue
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH 2/3] ps2: use a separate keyboard command reply queue |
Date: |
Mon, 9 Aug 2021 11:52:07 +0200 |
Hi,
> A PS/2 keyboard has a separate command reply queue that is
> independant of the key queue. This prevents that command replies
> and keyboard input mix. Keyboard command replies take precedence
> over queued keystrokes. A new keyboard command removes any
> remaining command replies from the command reply queue.
>
> Implement a separate keyboard command reply queue and clear the
> command reply queue before command execution. This brings the
> PS/2 keyboard emulation much closer to a real PS/2 keyboard.
It seems you place both queues in the existing 256-byte buffer,
probably to avoid breaking live migration.
Could you explain the logic a bit more, how the three pointers q->*ptr
variables play together here?
thanks,
Gerd
[PATCH 2/3] ps2: use a separate keyboard command reply queue, Volker Rümelin, 2021/08/07
- Re: [PATCH 2/3] ps2: use a separate keyboard command reply queue,
Gerd Hoffmann <=
[PATCH 1/3] ps2: use the whole ps2 buffer but keep queue size, Volker Rümelin, 2021/08/07
[PATCH-for-6.1? 0/3] ps2: Fix issue #501 and #502, Philippe Mathieu-Daudé, 2021/08/07