Re: [PATCH for 6.2 26/49] bsd-user: Create target specific vmparam.h

[Richard Henderson]

On 8/7/21 11:42 AM, Warner Losh wrote:
> +#define TARGET_MAXTSIZ  (128UL*1024*1024)   /* max text size */
> +#define TARGET_DFLDSIZ  (128UL*1024*1024)   /* initial data size limit */
> +#define TARGET_MAXDSIZ  (512UL*1024*1024)   /* max data size */
> +#define TARGET_DFLSSIZ  (8UL*1024*1024)     /* initial stack size limit */
> +#define TARGET_MAXSSIZ  (64UL*1024*1024)    /* max stack size */
> +#define TARGET_SGROWSIZ (128UL*1024)        /* amount to grow stack */

To-do list: KiB and MiB from units.h.

> +++ b/bsd-user/qemu.h
> @@ -44,7 +44,7 @@ extern enum BSDType bsd_type;
>   #include "target_arch.h"
>   #include "syscall_defs.h"
>   #include "target_syscall.h"
> -//#include "target_os_vmparam.h"
> +#include "target_os_vmparam.h"
>   //#include "target_os_signal.h"
>   //#include "hostdep.h"

Ah, I see.  Well, perhaps just squash the addition of the include to the patch that 
introduces the include?

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~