[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ui/sdl2: Check return value from g_setenv()
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH] ui/sdl2: Check return value from g_setenv() |
|
Date: |
Tue, 10 Aug 2021 10:57:38 +0200 |
On Mon, Aug 09, 2021 at 05:14:24PM +0100, Peter Maydell wrote:
> Setting environment variables can fail; check the return value
> from g_setenv() and bail out if we couldn't set SDL_VIDEODRIVER.
>
> Fixes: Coverity 1458798
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I followed existing practice in this function for how it
> deals with errors (ie, fprintf to stderr and exit).
> ---
Queued for 6.1 (given that the "drop setenv altogether" idea clearly is
6.2 material).
thanks,
Gerd