Re: [PATCH] MAINTAINERS: Name and email address change

[Daniel P . Berrangé]

On Tue, Aug 10, 2021 at 01:46:51PM +0200, Hanna Reitz wrote:
> On 10.08.21 13:29, Philippe Mathieu-Daudé wrote:
> > On 8/10/21 11:50 AM, Hanna Reitz wrote:
> > > I have changed my name and email address.  Update the MAINTAINERS file
> > > to match.
> > > 
> > > Signed-off-by: Hanna Reitz <hreitz@redhat.com>
> > > ---
> > >   MAINTAINERS | 8 ++++----
> > >   1 file changed, 4 insertions(+), 4 deletions(-)
> > I'd recommend you to also add an entry in .mailmap:
> > 
> > -- >8 --
> > diff --git a/.mailmap b/.mailmap
> > index 082ff893ab3..504839c84d3 100644
> > --- a/.mailmap
> > +++ b/.mailmap
> > @@ -53,6 +53,7 @@ Anthony Liguori <anthony@codemonkey.ws> Anthony
> > Liguori <aliguori@us.ibm.com>
> >   Filip Bozuta <filip.bozuta@syrmia.com> <filip.bozuta@rt-rk.com.com>
> >   Frederic Konrad <konrad@adacore.com> <fred.konrad@greensocs.com>
> >   Greg Kurz <groug@kaod.org> <gkurz@linux.vnet.ibm.com>
> > +Hanna Reitz <hreitz@redhat.com> <mreitz@redhat.com>
> >   Huacai Chen <chenhuacai@kernel.org> <chenhc@lemote.com>
> >   Huacai Chen <chenhuacai@kernel.org> <chenhuacai@loongson.cn>
> >   James Hogan <jhogan@kernel.org> <james.hogan@imgtec.com>
> > ---
> 
> Hu, I didn’t know there is such a thing.  Looks like I could even do
> 
> Hanna Reitz <hreitz@redhat.com> Max Reitz <mreitz@redhat.com>

With the line Philippe suggested, the rewrite will happen any time
the original email is seen. With this line, the rewrite will only
happen if both original name + email match. In practice this is
functionally the same, unless someone had variations in the spelling
of their real name over time, so either would work.

> Feels a bit like cheating, though...?

I wouldn't call it cheating. It is just an input for canonicalizing
contributors' identities, where there were changes in name or email
over time. It gives a more useful view to tools like 'git shortlog'
and 'git-dm' stats reports, such that all work over time will be
grouped together instead of split.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|