Re: [PATCH for 6.2 35/49] bsd-user: remove error_init

[Richard Henderson]

On 8/7/21 11:42 AM, Warner Losh wrote:
> From: Warner Losh <imp@FreeBSD.org>
>
> Error reporting isn't used, so gc it until it's used.
>
> Signed-off-by: Warner Losh  <imp@bsdimp.com>

That's not true.  At minimum, tcg/ uses Error during alloc_code_gen_buffer.


r~

> ---
>   bsd-user/main.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/bsd-user/main.c b/bsd-user/main.c
> index b5527537b4..7e20430fb7 100644
> --- a/bsd-user/main.c
> +++ b/bsd-user/main.c
> @@ -34,7 +34,6 @@
>   #include "qapi/error.h"
>   #include "qemu.h"
>   #include "qemu/config-file.h"
> -#include "qemu/error-report.h"
>   #include "qemu/path.h"
>   #include "qemu/help_option.h"
>   #include "qemu/module.h"
> @@ -223,7 +222,6 @@ int main(int argc, char **argv)
>   
>       save_proc_pathname(argv[0]);
>   
> -    error_init(argv[0]);
>       module_call_init(MODULE_INIT_TRACE);
>       qemu_init_cpu_list();
>       module_call_init(MODULE_INIT_QOM);