[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: remove redundant 'check-build' make target
|
From: |
Willian Rampazzo |
|
Subject: |
Re: [PATCH] build: remove redundant 'check-build' make target |
|
Date: |
Tue, 10 Aug 2021 14:35:58 -0300 |
On Tue, Aug 10, 2021 at 1:44 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> The 'check-build' make target was added as a way to build all the unit
> test binaries, since the standard 'all' target would not trigger this.
>
> Since the switch to meson, however, 'all' will now include the 'test'
> binaries. As a result, 'check-build' is a no-op:
>
> $ make all check-build
> ..snip lots of output...
> make: Nothing to be done for 'check-build'.
>
Confirmed!
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> .gitlab-ci.d/buildtest.yml | 9 ---------
> .gitlab-ci.d/crossbuild-template.yml | 6 +++---
> tests/Makefile.include | 3 ---
> 3 files changed, 3 insertions(+), 15 deletions(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>