[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/acpi: define PIIX4 acpi pci hotplug property strings at a
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] hw/acpi: define PIIX4 acpi pci hotplug property strings at a single place |
|
Date: |
Mon, 16 Aug 2021 11:21:11 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/16/21 10:32 AM, Ani Sinha wrote:
> Now that we have "acpi-pci-hotplug-with-bridge-support" PIIX4 PM property
> being
> used for both q35 and i440fx machine types, it is better that we defined this
> property string at a single place within a header file like other PIIX4
> properties. We can then use this single definition at all the places that
> needs
> it instead of duplicating the string everywhere. While at it, this change also
> adds a definition for "acpi-root-pci-hotplug" PIIX4 PM property and uses
> this definition at all places that were formally using the string value.
>
> Signed-off-by: Ani Sinha <ani@anisinha.ca>
> ---
> hw/acpi/ich9.c | 2 +-
> hw/acpi/piix4.c | 4 ++--
> hw/i386/acpi-build.c | 4 ++--
> hw/i386/pc.c | 4 ++--
> hw/i386/pc_q35.c | 2 +-
> include/hw/acpi/acpi.h | 2 ++
> 6 files changed, 10 insertions(+), 8 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>