[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] gitlab: don't run CI jobs by default on push to user for
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 2/2] gitlab: don't run CI jobs by default on push to user forks |
Date: |
Mon, 16 Aug 2021 13:45:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/16/21 1:35 PM, Daniel P. Berrangé wrote:
> On Mon, Aug 16, 2021 at 01:20:14PM +0200, Philippe Mathieu-Daudé wrote:
>> On 8/16/21 1:03 PM, Daniel P. Berrangé wrote:
>>>> (c) a subsystem maintainer is preparing a pull request
>>>>
>>>> Ideally, that should run the 'gating' set, to eliminate needless bounces
>>>> of the pull request; plus some subsystem-specific manual testing on
>>>> top. In practice, the 'full' set might be good enough.
>>>
>>> Yeah, the full/gating set is what I would thing subsys maintainers
>>> would want to use, to minimize risk that Peter's tests throw back
>>> the merge due to failure. The only difference of gating vs full
>>> is whether the acceptance tests run.
>>
>> "run" or "pass"?
>
> In 'full' set the acceptance test jobs are marked to allow to be
> triggered manually and won't affect pipeline status if they fail
I'd expect 'full' to *run* all tests, having acceptance tests
tagged with 'allow_failure', not 'manual', but I realize this
is a waste of resources. OK then.
> In 'gating' set the acceptance test jobs always run and are
> required to pass.
>
>
> Regards,
> Daniel
>
- [PATCH 0/2] gitlab: prepare for limited CI minutes by not running by default, Daniel P . Berrangé, 2021/08/12
- [PATCH 1/2] docs: split the CI docs into two files, Daniel P . Berrangé, 2021/08/12
- [PATCH 2/2] gitlab: don't run CI jobs by default on push to user forks, Daniel P . Berrangé, 2021/08/12
- Re: [PATCH 2/2] gitlab: don't run CI jobs by default on push to user forks, Cornelia Huck, 2021/08/16
- Re: [PATCH 2/2] gitlab: don't run CI jobs by default on push to user forks, Daniel P . Berrangé, 2021/08/16
- Re: [PATCH 2/2] gitlab: don't run CI jobs by default on push to user forks, Cornelia Huck, 2021/08/16
- Re: [PATCH 2/2] gitlab: don't run CI jobs by default on push to user forks, Daniel P . Berrangé, 2021/08/16
- Re: [PATCH 2/2] gitlab: don't run CI jobs by default on push to user forks, Philippe Mathieu-Daudé, 2021/08/16
Re: [PATCH 2/2] gitlab: don't run CI jobs by default on push to user forks, Thomas Huth, 2021/08/25