Re: [PATCH] tests/acceptance: Allow overwrite smp and memory

[Wainer dos Santos Moschetta]

Hi Ahmed,

Sorry for taking longer to reply you as I just returned from vacation.

On 8/2/21 7:22 PM, Ahmed Abouzied wrote:
> Removes the hard-coded values in setUp(). Class inheriting from
> avocado_qemu.LinuxTest can overwrite the default smp and memory instead.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/453
Thanks for working on that issue!
> Signed-off-by: Ahmed Abouzied <email@aabouzied.com>
> ---
>   tests/acceptance/avocado_qemu/__init__.py | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)

I would change the patch's subject as suggested by Philippe in another 
email. Apart from that, the change looks good to me. So:

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

> diff --git a/tests/acceptance/avocado_qemu/__init__.py 
> b/tests/acceptance/avocado_qemu/__init__.py
> index 2c4fef3e14..2639b89c84 100644
> --- a/tests/acceptance/avocado_qemu/__init__.py
> +++ b/tests/acceptance/avocado_qemu/__init__.py
> @@ -441,6 +441,8 @@ class LinuxTest(Test, LinuxSSHMixIn):
>       distro = None
>       username = 'root'
>       password = 'password'
> +    smp = '2'
> +    memory = '1024'
>   
>       def _set_distro(self):
>           distro_name = self.params.get(
> @@ -471,8 +473,8 @@ def _set_distro(self):
>       def setUp(self, ssh_pubkey=None, network_device_type='virtio-net'):
>           super(LinuxTest, self).setUp()
>           self._set_distro()
> -        self.vm.add_args('-smp', '2')
> -        self.vm.add_args('-m', '1024')
> +        self.vm.add_args('-smp', self.smp)
> +        self.vm.add_args('-m', self.memory)
>           # The following network device allows for SSH connections
>           self.vm.add_args('-netdev', 'user,id=vnet,hostfwd=:127.0.0.1:0-:22',
>                            '-device', '%s,netdev=vnet' % network_device_type)