Re: [PATCH 1/2] Acceptance Tests: add standard clean up at test tearDown()

[Wainer dos Santos Moschetta]

Hi,

On 8/3/21 4:34 PM, Cleber Rosa wrote:
> The avocado.Test class, used as the basis of the avocado_qemu.Test
> class, performs a clean of temporary directories up as part of its own
> tearDown() implementation.
>
> But the avocado_qemu.Test class is currently missing the same clean
> up, as it implemented its own tearDown() method without resorting to
> the upper class behavior.
Good catch Peter!
> This brings avocado_qemu.Test behavior in sync with the standard
> avocado.Test behavior and prevents temporary directories from
> cluttering the test results directory (unless instructed to do so with
> Avocado's "--keep-tmp" option).
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>   tests/acceptance/avocado_qemu/__init__.py | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/acceptance/avocado_qemu/__init__.py 
> b/tests/acceptance/avocado_qemu/__init__.py
> index 2c4fef3e14..1e807e2e55 100644
> --- a/tests/acceptance/avocado_qemu/__init__.py
> +++ b/tests/acceptance/avocado_qemu/__init__.py
> @@ -276,6 +276,7 @@ def tearDown(self):
>           for vm in self._vms.values():
>               vm.shutdown()
>           self._sd = None
> +        super(Test, self).tearDown()

Could you use the new form of super [1] to make the pylint happier?

[1] https://www.python.org/dev/peps/pep-3135/

Thanks!

- Wainer

>   
>       def fetch_asset(self, name,
>                       asset_hash=None, algorithm=None,