[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 12/25] python/aqmp: add AsyncProtocol._readline() method
From: |
Eric Blake |
Subject: |
Re: [PATCH v3 12/25] python/aqmp: add AsyncProtocol._readline() method |
Date: |
Tue, 17 Aug 2021 14:36:10 -0500 |
User-agent: |
NeoMutt/20210205-719-68949a |
On Tue, Aug 03, 2021 at 02:29:28PM -0400, John Snow wrote:
> This is added as a courtesy: many protocols are line-based, including
> QMP. Putting it in AsyncProtocol lets us keep the QMP class
> implementation just a pinch more abstract.
>
> (And, if we decide to add a QTEST implementation later, it will need
> this, too. (Yes, I have a QTEST implementation.))
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/aqmp/protocol.py | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH v3 11/25] python/aqmp: add _cb_inbound and _cb_outbound logging hooks, (continued)
- [PATCH v3 11/25] python/aqmp: add _cb_inbound and _cb_outbound logging hooks, John Snow, 2021/08/03
- [PATCH v3 04/25] python/aqmp: add asyncio compatibility wrappers, John Snow, 2021/08/03
- [PATCH v3 09/25] python/aqmp: add AsyncProtocol.accept() method, John Snow, 2021/08/03
- [PATCH v3 10/25] python/aqmp: add configurable read buffer limit, John Snow, 2021/08/03
- [PATCH v3 14/25] python/aqmp: add well-known QMP object models, John Snow, 2021/08/03
- [PATCH v3 12/25] python/aqmp: add AsyncProtocol._readline() method, John Snow, 2021/08/03
- Re: [PATCH v3 12/25] python/aqmp: add AsyncProtocol._readline() method,
Eric Blake <=
- [PATCH v3 13/25] python/aqmp: add QMP Message format, John Snow, 2021/08/03
- [PATCH v3 15/25] python/aqmp: add QMP event support, John Snow, 2021/08/03
- [PATCH v3 17/25] python/aqmp: add QMP protocol support, John Snow, 2021/08/03
- [PATCH v3 16/25] python/pylint: disable too-many-function-args, John Snow, 2021/08/03
- [PATCH v3 18/25] python/pylint: disable no-member check, John Snow, 2021/08/03
- [PATCH v3 19/25] python/aqmp: Add message routing to QMP protocol, John Snow, 2021/08/03
- [PATCH v3 20/25] python/aqmp: add execute() interfaces, John Snow, 2021/08/03
- [PATCH v3 22/25] python/aqmp: add asyncio_run compatibility wrapper, John Snow, 2021/08/03