[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] memory: Have 'info mtree' remove duplicated Address Space
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v3] memory: Have 'info mtree' remove duplicated Address Space information |
|
Date: |
Mon, 23 Aug 2021 10:28:08 +0100 |
On Mon, 23 Aug 2021 at 10:20, David Hildenbrand <david@redhat.com> wrote:
>
> On 23.08.21 10:54, Philippe Mathieu-Daudé wrote:
> > +static void mtree_print_as(gpointer key, gpointer value, gpointer
> > user_data)
> > +{
> > + MemoryRegion *mr = key;
> > + GSList *as_same_root_mr_list = value;
> > + struct AddressSpaceInfo *asi = user_data;
>
> Reverse Christmas tree?
This has never been part of the QEMU style guidelines
and I would oppose our adding it. It would gain us very little,
the codebase doesn't consistently follow that rule today so
it wouldn't be preserving an existing consistency of style,
and it would be yet another weird stylistic issue that trips
people up and requires patch repins.
-- PMM