qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/4] target/arm/cpu64: Validate sve vector lengths are sup


From: Richard Henderson
Subject: Re: [PATCH v2 4/4] target/arm/cpu64: Validate sve vector lengths are supported
Date: Mon, 23 Aug 2021 11:04:49 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 8/23/21 9:06 AM, Andrew Jones wrote:
Future CPU types may specify which vector lengths are supported.
We can apply nearly the same logic to validate those lengths
as we do for KVM's supported vector lengths. We merge the code
where we can, but unfortunately can't completely merge it because
KVM requires all vector lengths, power-of-two or not, smaller than
the maximum enabled length to also be enabled. The architecture
only requires all the power-of-two lengths, though, so TCG will
only enforce that.

Signed-off-by: Andrew Jones <drjones@redhat.com>
---
  target/arm/cpu64.c | 101 ++++++++++++++++++++-------------------------
  1 file changed, 45 insertions(+), 56 deletions(-)


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

+        } else {
+            if (kvm_enabled()) {

Nit: better as

    } else if (...) {

if I'm reading all of the diff context correctly.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]