Re: [PATCH v2 07/43] bsd-user: move arch specific defines out of elfload.c

[Warner Losh]

> On Aug 26, 2021, at 10:19 PM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> 
> On 8/26/21 11:11 PM, imp@bsdimp.com wrote:
>> From: Warner Losh <imp@bsdimp.com>
>> 
>> Move the arcitecture specific defines to target_arch_elf.h and delete
> 
> Typo "architecture"

Thanks

>> them from elfload.c. unifdef as appropriate for i386 vs x86_64
> 
> "un-ifdef" or untangle?

I’ve reworded to make it clearer what I’ve done: only retain the
ifdefs relevant for i386 and x86_64.

Warner

>> versions. Add the copyright/license comments, and guard ifdefs.
>> 
>> Signed-off-by: Warner Losh <imp@bsdimp.com>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> bsd-user/elfload.c                | 81 +------------------------------
>> bsd-user/i386/target_arch_elf.h   | 76 +++++++++++++++++++++++++++++
>> bsd-user/x86_64/target_arch_elf.h | 64 ++++++++++++++++++++++++
>> 3 files changed, 142 insertions(+), 79 deletions(-)
>> create mode 100644 bsd-user/i386/target_arch_elf.h
>> create mode 100644 bsd-user/x86_64/target_arch_elf.h

signature.asc
Description: Message signed with OpenPGP