Re: [PATCH 1/3] escc: checkpatch fixes

[Peter Maydell]

On Sun, 29 Aug 2021 at 11:04, Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>  hw/char/escc.c | 160 +++++++++++++++++++++++++++++--------------------
>  1 file changed, 96 insertions(+), 64 deletions(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

You might want to fix this existing typo:

> @@ -300,21 +308,25 @@ static void escc_reset(DeviceState *d)
>  static inline void set_rxint(ESCCChannelState *s)
>  {
>      s->rxint = 1;
> -    /* XXX: missing daisy chainnig: escc_chn_b rx should have a lower 
> priority
> -       than chn_a rx/tx/special_condition service*/
> +    /*
> +     * XXX: missing daisy chainnig: escc_chn_b rx should have a lower 
> priority
> +     * than chn_a rx/tx/special_condition service
> +     */

"daisy chaining"


> -    // MSC protocol specify two extra motion bytes
> +    /* MSC protocol specify two extra motion bytes */

and this should be "specifies".

-- PMM