Re: [PATCH v3 28/66] plugins: Reorg arguments to qemu_plugin_vcpu_mem_cb

[Philippe Mathieu-Daudé]

On 8/18/21 9:18 PM, Richard Henderson wrote:
> Use the MemOpIdx directly, rather than the rearrangement
> of the same bits currently done by the trace infrastructure.
> Pass in enum qemu_plugin_mem_rw so that we are able to treat
> read-modify-write operations as a single operation.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  include/qemu/plugin.h         | 26 ++++++++++++++++++++++++--
>  accel/tcg/cputlb.c            |  4 ++--
>  accel/tcg/plugin-gen.c        |  5 ++---
>  accel/tcg/user-exec.c         | 28 ++++++++++++++--------------
>  plugins/api.c                 | 19 +++++++++++--------
>  plugins/core.c                | 10 +++++-----
>  tcg/tcg-op.c                  | 30 +++++++++++++++++++++---------
>  accel/tcg/atomic_common.c.inc | 13 +++----------
>  8 files changed, 82 insertions(+), 53 deletions(-)

(now v3)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>