[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 08/15] target/i386: Added consistency checks for CR4
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PULL 08/15] target/i386: Added consistency checks for CR4 |
|
Date: |
Tue, 31 Aug 2021 18:12:04 +0100 |
|
User-agent: |
Mutt/2.0.7 (2021-05-04) |
On Tue, Aug 31, 2021 at 06:03:04PM +0100, Richard W.M. Jones wrote:
> On Thu, Jul 22, 2021 at 05:36:05PM +0200, Paolo Bonzini wrote:
> > From: Lara Lazier <laramglazier@gmail.com>
> >
> > All MBZ bits in CR4 must be zero. (APM2 15.5)
> > Added reserved bitmask and added checks in both
> > helper_vmrun and helper_write_crN.
> >
> > Signed-off-by: Lara Lazier <laramglazier@gmail.com>
> > Message-Id: <20210721152651.14683-2-laramglazier@gmail.com>
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> FYI this commit causes a regression with -cpu max (regression analyzed
> by Daniel Berrange). See:
Specifically this commit breaks the ability to boot current fedora
kernels with --cpu max. Disabling 'la57' feature makes it work
again. Similarly enabling 'la57' on any named CPU model makes that
then break.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|