[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: qemu-sockets: account for trailing \0 byte in unix socket pathname
From: |
Michael Tokarev |
Subject: |
Re: qemu-sockets: account for trailing \0 byte in unix socket pathname |
Date: |
Tue, 31 Aug 2021 20:47:43 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
31.08.2021 20:38, Daniel P. Berrangé wrote:
...
So it looks like libvirt provides an unnamed socket there, --
maybe from a socketpair(2)?
Yes
No, libvirt binds to a named socket path and passes in a pre-opened
FD for the listener socket. There shouldn't be any socketpair involved.
Here's some more info from the original bugreport:
31.08.2021 00:20, dann frazier wrote:
> Aha! It seems that the important difference is whether or not the
> virt-manager GUI window for the VM is active. If it is active, the VM
> crashes regardless of how it is started (virsh console start/clicking
> "play" button). If the GUI is not active, the VM always works.
>
> With this knowledge I am able to confidently say that reverting
> 4cfd970ec1 *does* reliably avoid the problem.
We'll try to figure out the calltrace, where this socket is coming from..
/mjt