[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/9] qapi: make blockdev-add a coroutine command
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 2/9] qapi: make blockdev-add a coroutine command |
Date: |
Mon, 06 Sep 2021 21:28:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> We are going to support nbd reconnect on open in a next commit. This
> means that we want to do several connection attempts during some time.
> And this should be done in a coroutine, otherwise we'll stuck.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> qapi/block-core.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 06674c25c9..6e4042530a 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -4219,7 +4219,8 @@
> # <- { "return": {} }
> #
> ##
> -{ 'command': 'blockdev-add', 'data': 'BlockdevOptions', 'boxed': true }
> +{ 'command': 'blockdev-add', 'data': 'BlockdevOptions', 'boxed': true,
> + 'coroutine': true }
>
> ##
> # @blockdev-reopen:
Why is this safe?
Prior discusson:
Message-ID: <87lfq0yp9v.fsf@dusky.pond.sub.org>
https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg04921.html
[PATCH v3 3/9] nbd: allow reconnect on open, with corresponding new options, Vladimir Sementsov-Ogievskiy, 2021/09/06
[PATCH v3 9/9] iotests: add nbd-reconnect-on-open test, Vladimir Sementsov-Ogievskiy, 2021/09/06
[PATCH v3 5/9] nbd/client-connection: improve error message of cancelled attempt, Vladimir Sementsov-Ogievskiy, 2021/09/06