[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 3/7] spapr_drc.c: do not error_report() when drc->dev->id == N
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH v8 3/7] spapr_drc.c: do not error_report() when drc->dev->id == NULL |
Date: |
Mon, 6 Sep 2021 21:47:51 -0300 |
The error_report() call in drc_unisolate_logical() is not considering
that drc->dev->id can be NULL, and the underlying functions error_report()
calls to do its job (vprintf(), g_strdup_printf() ...) has undefined
behavior when trying to handle "%s" with NULL arguments.
Besides, there is no utility into reporting that an unknown device was
rejected by the guest.
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
hw/ppc/spapr_drc.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
index a2f2634601..a4d9496f76 100644
--- a/hw/ppc/spapr_drc.c
+++ b/hw/ppc/spapr_drc.c
@@ -167,8 +167,11 @@ static uint32_t drc_unisolate_logical(SpaprDrc *drc)
}
drc->unplug_requested = false;
- error_report("Device hotunplug rejected by the guest "
- "for device %s", drc->dev->id);
+
+ if (drc->dev->id) {
+ error_report("Device hotunplug rejected by the guest "
+ "for device %s", drc->dev->id);
+ }
/*
* TODO: send a QAPI DEVICE_UNPLUG_ERROR event when
--
2.31.1
- [PATCH v8 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event, Daniel Henrique Barboza, 2021/09/06
- [PATCH v8 2/7] spapr.c: handle dev->id in spapr_memory_unplug_rollback(), Daniel Henrique Barboza, 2021/09/06
- [PATCH v8 1/7] memory_hotplug.c: handle dev->id = NULL in acpi_memory_hotplug_write(), Daniel Henrique Barboza, 2021/09/06
- [PATCH v8 3/7] spapr_drc.c: do not error_report() when drc->dev->id == NULL,
Daniel Henrique Barboza <=
- [PATCH v8 5/7] qapi/qdev.json: add DEVICE_UNPLUG_GUEST_ERROR QAPI event, Daniel Henrique Barboza, 2021/09/06
- [PATCH v8 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc, Daniel Henrique Barboza, 2021/09/06
- [PATCH v8 6/7] spapr: use DEVICE_UNPLUG_GUEST_ERROR to report unplug errors, Daniel Henrique Barboza, 2021/09/06
- [PATCH v8 7/7] memory_hotplug.c: send DEVICE_UNPLUG_GUEST_ERROR in acpi_memory_hotplug_write(), Daniel Henrique Barboza, 2021/09/06
- Re: [PATCH v8 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event, David Gibson, 2021/09/06