qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 16/53] target/microblaze: convert to use format_state inst


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 16/53] target/microblaze: convert to use format_state instead of dump_state
Date: Wed, 15 Sep 2021 09:18:49 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 9/14/21 4:20 PM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  target/microblaze/cpu.c       |  2 +-
>  target/microblaze/cpu.h       |  2 +-
>  target/microblaze/translate.c | 45 ++++++++++++++++++-----------------
>  3 files changed, 25 insertions(+), 24 deletions(-)

>      for (i = 0; i < 32; i++) {
> -        qemu_fprintf(f, "r%2.2d=%08x%c",
> -                     i, env->regs[i], i % 4 == 3 ? '\n' : ' ');
> +        g_string_append_printf(buf, "r%2.2d=%08x%c",
> +                               i, env->regs[i], i % 4 == 3 ? '\n' : ' ');
>      }
> -    qemu_fprintf(f, "\n");
> +    g_string_append_printf(buf, "\n");

g_string_append_c(), otherwise:

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

>  }
>  
>  void mb_tcg_init(void)
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]